| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Alexander Lakhin <exclusion(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Daniel Verite <daniel(at)manitou-mail(dot)org>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Sandro Santilli <strk(at)kbt(dot)io>, Regina Obe <lr(at)pcorp(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Order changes in PG16 since ICU introduction |
| Date: | 2023-05-16 16:47:51 |
| Message-ID: | 504bc10a9ad8d143f505e66be2a0060e50b45677.camel@j-davis.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 2023-05-16 at 19:00 +0300, Alexander Lakhin wrote:
> I'm not sure about the proposed change in icu_from_uchar(). It seems
> that
> len_result + 1 bytes should always be enough for the result string
> terminated
> with NUL. If that's not true (we want to protect from some ICU bug
> here),
> then the change should be backpatched?
I believe it's enough and I'm not aware of any bug there so no backport
is required.
I added checks in places that were (a) checking for U_FAILURE; and (b)
expecting the result to be NUL-terminated. That's mostly callers of
uloc_getLanguage(), where I was not quite paranoid enough.
There were a couple other places though, and I went ahead and added
checks there out of paranoia, too. One was ucnv_fromUChars(), and the
other was uloc_canonicalize().
Regards,
Jeff Davis
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joel Jacobson | 2023-05-16 17:15:03 | Re: Should CSV parsing be stricter about mid-field quotes? |
| Previous Message | Alexander Lakhin | 2023-05-16 16:00:00 | Re: Order changes in PG16 since ICU introduction |