| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_upgrade del/rmdir path fix |
| Date: | 2012-09-05 00:54:22 |
| Message-ID: | 5046A2BE.5090009@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 09/04/2012 02:25 PM, Andrew Dunstan wrote:
>
> On 09/04/2012 10:42 AM, Alvaro Herrera wrote:
>
>>
>> Somehow the verbose reporting of user relation files being copied does
>> not seem exceedingly useful; and I don't remember seeing that on Linux.
>>
>
>
> Yeah, and it does something odd anyway when it's not writing to a
> terminal. Can we get rid of it, or make it only work in verbose mode?
>
>
The attached is an attempt to fix this. I think it handles most of
what's wrong with this. (The patch is bigger because the code currently
uses a variable called "fileno" - not a good idea.)
cheers
andrew
| Attachment | Content-Type | Size |
|---|---|---|
| pg_upgrade_relfilenode_log.patch | text/x-patch | 4.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2012-09-05 00:56:33 | Re: pg_upgrade diffs on WIndows |
| Previous Message | Andrew Dunstan | 2012-09-05 00:51:03 | Re: build farm machine using <make -j 8> mixed results |