Re: pg_upgrade del/rmdir path fix

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_upgrade del/rmdir path fix
Date: 2012-09-04 03:05:40
Message-ID: 50457004.3040909@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 09/03/2012 10:41 PM, Bruce Momjian wrote:
> On Mon, Sep 3, 2012 at 02:30:18PM -0400, Andrew Dunstan wrote:
>> Here is a patch against 9.2 sources (it applies with offsets to HEAD
>> too) to fix the problem that pg_upgrade can write paths in arguments
>> for Windows builtin commands (specifically DEL and RMDIR) with the
>> wrong path separator style. This should be applied all the way back
>> to 9.0.
> Wow, my guess is that no one ever ran those auto-generated scripts on
> Windows. Thanks.
>

Lucky for us the test script does or I'd never have noticed either.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2012-09-04 03:11:23 Re: Proof of concept: standalone backend with full FE/BE protocol
Previous Message Bruce Momjian 2012-09-04 02:53:02 Re: [GENERAL] Date conversion using day of week