Re: Better error message for select_common_type()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Gregory Stark <stark(at)enterprisedb(dot)com>
Cc: "Peter Eisentraut" <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Better error message for select_common_type()
Date: 2008-03-18 01:01:13
Message-ID: 5032.1205802073@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Gregory Stark <stark(at)enterprisedb(dot)com> writes:
> "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
>> Or we could apply Peter's patch more or less as-is, but I don't like
>> that. I don't think it solves the stated problem: if you know that CASE
>> branches 3 and 5 don't match, that still doesn't help you in a monster
>> query with lots of CASEs. I think we can and must do better.

> Do we have something more helpful than "branches 3 and 5"?

That's exactly the point of discussion. A parser location is what we
need, the problem is that this patch doesn't provide it.

> Perhaps printing the actual transformed expressions?

Don't think it solves the problem either. For instance, if there are
a hundred references to variable X in your query, printing "X" isn't
going to get you far.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 2008-03-18 01:09:31 Re: [HACKERS] Proposal: new large object API
Previous Message Tom Lane 2008-03-18 00:58:33 Re: New style of hash join proposal