Re: pgsql: Add compat file for dynamically loading the functions that MinGW

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add compat file for dynamically loading the functions that MinGW
Date: 2007-10-29 13:54:04
Message-ID: 5019.1193666044@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

mha(at)postgresql(dot)org (Magnus Hagander) writes:
> Add compat file for dynamically loading the functions that MinGW is missing
> the imports for. Add RegisterWaitForSingleObject() to the list of such
> functions, which should take care of the current buildfarm breakage.

Trivial stylistic complaint: shouldn't the _RegisterWaitForSingleObject
variable be declared static? IMHO variables (and functions) should
always be static unless there is an explicit intent to access them from
other modules.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2007-10-29 14:04:29 Re: pgsql: Add compat file for dynamically loading the functions that MinGW
Previous Message Teodor Sigaev 2007-10-29 13:49:51 pgsql: Fix coredump during replay WAL after crash.