Re: pg_dump future problem.

From: Philip Warner <pjw(at)rhyme(dot)com(dot)au>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_dump future problem.
Date: 2003-05-05 15:15:08
Message-ID: 5.1.0.14.0.20030506010434.047fc048@mail.rhyme.com.au
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At 10:58 AM 5/05/2003 -0400, Tom Lane wrote:
>Philip Warner <pjw(at)rhyme(dot)com(dot)au> writes:
>
> > In this case I think they have shot themselves in the foot; the docs
> > clearly state that setval/3 is for internal pg_dump use only.
>
>There is no such statement visible in
>http://www.ca.postgresql.org/users-lounge/docs/7.3/postgres/functions-sequence.html
>nor do I find it anywhere else in the current documents.

Good point. It's only in the source code. I thought I had updated the docs
as well...

> > It is also
> > not to be relied upon when there are more than one connection to the db
> > updating the sequence.
>
>Any more or less so than either two-parameter SETVAL or the proposed
>ALTER TABLE? I don't see how.

My recollection is that setting is_called is more fragile than just setting
the sequence value, so it not wise to use in general.

>It probably would look different if we were starting from scratch
>... but we aren't, and I don't see any problems here that are large
>enough to justify starting over.

I'm not actually suggesting starting over. Just presenting a nicer
interface and fixing a bug in the process, rather than building yet another
user-visible function as a band-aid solution.

----------------------------------------------------------------
Philip Warner | __---_____
Albatross Consulting Pty. Ltd. |----/ - \
(A.B.N. 75 008 659 498) | /(@) ______---_
Tel: (+61) 0500 83 82 81 | _________ \
Fax: (+61) 03 5330 3172 | ___________ |
Http://www.rhyme.com.au | / \|
| --________--
PGP key available upon request, | /
and from pgp5.ai.mit.edu:11371 |/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephan Szabo 2003-05-05 15:20:23 Re: Why are triggers semi-deferred?
Previous Message Tom Lane 2003-05-05 14:58:45 Re: pg_dump future problem.