Re: Add LZ4 compression in pg_dump

From: gkokolatos(at)pm(dot)me
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Rachel Heaton <rachelmheaton(at)gmail(dot)com>
Subject: Re: Add LZ4 compression in pg_dump
Date: 2022-12-06 15:52:01
Message-ID: 4wfmZ9BuGbkM6JXggut4g_gPl1hLbVeUwPEQh5nGgzlKCgnbtRaw7-nPcyPelGdG8ttH9A7vgyX_Z2fwZxuqHt1xENg9mqDfP_94qoZ5WxQ=@pm.me
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

------- Original Message -------
On Tuesday, December 6th, 2022 at 1:22 AM, Michael Paquier <michael(at)paquier(dot)xyz> wrote:

>
>
> On Mon, Dec 05, 2022 at 12:48:28PM +0000, gkokolatos(at)pm(dot)me wrote:
>
> This is where the fun is. What you are doing here is more complete,
> and we would make sure that the custom and data directory would always
> see their contents compressed by default. And it would have caught
> the bug you mentioned upthread for the custom format.

Thank you very much Michael.

> I have kept things as you proposed at the end, added a few comments,
> documented the new command_like and an extra command_like for
> defaults_dir_format. Glad to see this addressed, thanks!

Please find attached v17, which builds on top of what is already
committed. I dare to think 0001 as ready to be reviewed. 0002 is
also complete albeit with some documentation gaps.

Cheers,
//Georgios

> --
> Michael

Attachment Content-Type Size
v17-0001-Prepare-pg_dump-internals-for-additional-compres.patch text/x-patch 22.0 KB
v17-0002-Introduce-Compressor-API-in-pg_dump.patch text/x-patch 62.2 KB
v17-0003-Add-LZ4-compression-in-pg_-dump-restore.patch text/x-patch 29.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-12-06 16:07:01 Re: Error-safe user functions
Previous Message Andrew Dunstan 2022-12-06 15:43:03 Re: Error-safe user functions