Re: Patches that don't apply or don't compile: 2017-09-12

From: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
To: Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>
Cc: pgsql-hackers(at)postgresql(dot)org, Daniel Gustafsson <daniel(at)yesql(dot)se>
Subject: Re: Patches that don't apply or don't compile: 2017-09-12
Date: 2017-09-13 12:37:08
Message-ID: 4fb6c7d4-4c4f-7204-42c8-b34048793a72@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Aleksander,

On 09/13/2017 11:49 AM, Aleksander Alekseev wrote:
> Hi Tomas,
>
> I appreciate your feedback, although it doesn't seem to be completely
> fair. Particularly:
>
>> You gave everyone about 4 hours to object
>
> This is not quite accurate since my proposal was sent 2017-09-11
> 09:41:32 and this thread started - 2017-09-12 14:14:55.
>

Understood. I didn't really consider the first message to be a proposal
with a deadline, as it starts with "here's a crazy idea" and it's not
immediately clear that you intend to proceed with it immediately, and
that you expect people to object.

The message I referenced is a much clearer on this.

>> You just changed the status of 10-15% open patches. I'd expect
>> things like this to be consulted with the CF manager, yet I don't see
>> any comments from Daniel.
>
> Agree, that was clearly a mistake, I had to add Daniel to CC. Sorry I
> didn't do that. I've returned all affected patches back to "Needs
> Review". On the bright side while doing this I've noticed that many
> patches were already updated by their authors.
>

Yeah.

regards

--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Prabhat Sahu 2017-09-13 12:51:06 Re: Parallel Hash take II
Previous Message Peter Eisentraut 2017-09-13 12:36:08 Re: [COMMITTERS] pgsql: Logical replication support for initial data copy