| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Andrey Borodin <amborodin86(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Jacob Champion <jchampion(at)timescale(dot)com>, Daniil Zakhlystov <usernamedt(at)yandex-team(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
| Subject: | Re: libpq compression (part 2) |
| Date: | 2022-11-17 15:09:22 |
| Message-ID: | 4fab82d1-a0f5-0d01-4d6c-0b780b5eea3a@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 17.11.22 01:27, Andrey Borodin wrote:
> Also I've found one more TODO item for the patch. Currently in
> fe-connect.c patch is doing buffer reset:
> conn->inStart = conn->inCursor = conn->inEnd = 0;
> This effectively consumes butes up tu current cursor. However, packet
> inspection is continued. The patch works because in most cases
> following code will issue re-read of message. Coincidentally.
> /* Get the type of request. */
> if (pqGetInt((int *) &areq, 4, conn))
> {
> /* We'll come back when there are more data */
> return PGRES_POLLING_READING;
> }
Note that the above code was just changed in dce92e59b1. I don't know
how that affects this patch set.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Japin Li | 2022-11-17 15:19:26 | Re: redundant check of msg in does_not_exist_skipping |
| Previous Message | Japin Li | 2022-11-17 15:06:22 | Re: redundant check of msg in does_not_exist_skipping |