Re: Checks in RegisterBackgroundWorker.()

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Checks in RegisterBackgroundWorker.()
Date: 2023-10-09 08:52:58
Message-ID: 4f964a44-fc90-4e43-8edc-f51e0b1c53df@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 06/10/2023 13:13, Thomas Munro wrote:
> On Thu, Sep 28, 2023 at 9:46 AM Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>> Subject: [PATCH v2 3/3] Fix misleading comment on StartBackgroundWorker().
>
> LGTM. Hmm, maybe I would have called that function
> "BackgroundWorkerMain()" like several other similar things, but that's
> not important.

That's a good idea. I renamed it to BackgroundWorkerMain().

Pushed with that change, thanks for the review!

--
Heikki Linnakangas
Neon (https://neon.tech)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2023-10-09 08:59:23 Re: [PoC] pg_upgrade: allow to upgrade publisher nodeHayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>
Previous Message Stefan Kaltenbrunner 2023-10-09 08:38:54 Re: Where can I find the doxyfile?