From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
---|---|
To: | Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, Grigory Smolkin <g(dot)smolkin(at)postgrespro(dot)ru>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: history file on replica and double switchover |
Date: | 2020-09-04 04:53:24 |
Message-ID: | 4f7379a6-b196-70fe-708d-84a2672b3c22@oss.nttdata.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2020/09/04 8:29, Anastasia Lubennikova wrote:
> On 27.08.2020 16:02, Grigory Smolkin wrote:
>> Hello!
>>
>> I`ve noticed, that when running switchover replica to master and back to replica, new history file is streamed to replica, but not archived,
>> which is not great, because it breaks PITR if archiving is running on replica. The fix looks trivial.
>> Bash script to reproduce the problem and patch are attached.
>>
> Thanks for the report. I agree that it looks like a bug.
+1
+ /* Mark history file as ready for archiving */
+ if (XLogArchiveMode != ARCHIVE_MODE_OFF)
+ XLogArchiveNotify(fname);
I agree that history file should be archived in the standby when
archive_mode=always. But why do we need to do when archive_mode=on?
I'm just concerned about the case where the primary and standby
have the shared archive area, and archive_mode is on.
> For some reason, patch failed to apply on current master, even though I don't see any difference in the code.
> I'll attach this thread to the next commitfest, so it doesn't get lost.
Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2020-09-04 05:46:52 | Re: Fix for configure error in 9.5/9.6 on macOS 11.0 Big Sur |
Previous Message | Fujii Masao | 2020-09-04 03:42:31 | Re: New statistics for tuning WAL buffer size |