Re: Proposal - Allow extensions to set a Plan Identifier

From: Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com>
To: Sami Imseih <samimseih(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Andrei Lepikhov <lepihov(at)gmail(dot)com>
Cc: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Lukas Fittl <lukas(at)fittl(dot)com>
Subject: Re: Proposal - Allow extensions to set a Plan Identifier
Date: 2025-03-18 11:46:11
Message-ID: 4f32c878-34e2-4f4a-8575-bf343ba6e037@tantorlabs.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Thank you for the patches. They're very important for many extensions.

I've debugged them using simple extensions pg_stat_statements and
auto_explain, specifically checking cases involving PlannedStmt
and pg_stat_get_activity - , and haven't encountered any issues so far.

However, I have a question: what value should planid have when we
execute the standard planner without using a planner_hook? For example,
if pg_stat_statementsis disabled, would planid default to zero? If zero
is the expected default, should we explicitly write this behavior?

result->planid = 0;

--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2025-03-18 11:47:25 Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.
Previous Message Alexander Korotkov 2025-03-18 11:42:17 Re: Proposal: Adding compression of temporary files