| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de>, Petr Jelinek <petr(at)2ndquadrant(dot)com> |
| Cc: | Craig Ringer <craig(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Erik Rijkers <er(at)xs4all(dot)nl>, Steve Singer <steve(at)ssinger(dot)info> |
| Subject: | Re: Logical Replication WIP |
| Date: | 2016-09-14 18:20:02 |
| Message-ID: | 4f0bb8cb-7dd4-7242-f9ec-55ce421e1f09@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 9/14/16 11:21 AM, Andres Freund wrote:
>> + ExecInsert(NULL, /* mtstate is only used for onconflict handling which we don't support atm */
>> > + remoteslot,
>> > + remoteslot,
>> > + NIL,
>> > + ONCONFLICT_NONE,
>> > + estate,
>> > + false);
> I have *severe* doubts about just using the (newly) exposed functions
> 1:1 here.
It is a valid concern, but what is the alternative? ExecInsert() and
the others appear to do exactly the right things that are required.
Are your concerns mainly philosophical about calling into internal
executor code, or do you have technical concerns that this will not do
the right thing in some cases?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kuntal Ghosh | 2016-09-14 18:23:15 | Re: WAL consistency check facility |
| Previous Message | Robert Haas | 2016-09-14 18:10:05 | Re: Vacuum: allow usage of more than 1GB of work mem |