From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: allow running parts of src/tools/msvc/ under not Windows |
Date: | 2020-02-21 20:04:02 |
Message-ID: | 4de70a14-9e6a-2c9a-a80f-dca4e8723dbe@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2020-02-21 05:00, Michael Paquier wrote:
> On Thu, Feb 20, 2020 at 09:31:32AM -0500, Tom Lane wrote:
>> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
>>> The main benefit is that if you make "blind" edits in the Perl files,
>>> you can verify them easily, first by seeing that the Perl code runs,
>>> second, depending on the circumstances, by diffing the created project
>>> files. Another is that if you do some nontrivial surgery in makefiles,
>>> you can check whether the Perl code can still process them. So the
>>> benefit is mainly that you can iterate faster when working on build
>>> system related things. You still need to do a full test on Windows at
>>> the conclusion, but then hopefully with a better chance of success.
>>
>> I see. No objection then.
>
> None from here either, and the patch is working correctly.
committed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2020-02-21 20:22:12 | Re: Memory-Bounded Hash Aggregation |
Previous Message | Peter Eisentraut | 2020-02-21 19:58:43 | pgsql: Allow running src/tools/msvc/mkvcbuild.pl under not Windows |