From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
---|---|
To: | Andreas Karlsson <andreas(at)proxel(dot)se>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pure parsers and reentrant scanners |
Date: | 2024-12-26 18:27:26 |
Message-ID: | 4d6a4426-6cda-4687-817a-42bd706e18c5@eisentraut.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 22.12.24 22:43, Andreas Karlsson wrote:
> On 12/19/24 9:57 PM, Peter Eisentraut wrote:
>> Here is an updated patch set on top of what has been committed so far,
>> with all the issues you pointed out addressed.
>
> Other than the discussion of how old versions of flex we should support
> I think this set of patches is ready to be committed. I looked at it
> again and everything looks good.
I have committed these except the plpgsql one, which was still work in
progress. But I have progressed on this now and also converted the
parser and put the local state into yyextra. This gets rid of all
internal global state now. The patches for this are attached. It's a
lot of churn, but otherwise pretty standard stuff.
Along the way I noticed that the flex documentation now recommends a
different way to set the yyextra type. So I have changed the ones we
already have to that newer style. I inspected the generated C code and
there wasn't any significant difference, so I'm not sure, but I figure
if we're making changes in this area we might as well use the modern style.
Attachment | Content-Type | Size |
---|---|---|
v3-0001-flex-code-modernization-Replace-YY_EXTRA_TYPE-def.patch | text/plain | 5.4 KB |
v3-0002-plpgsql-reentrant-scanner.patch | text/plain | 52.1 KB |
v3-0003-plpgsql-pure-parser.patch | text/plain | 65.4 KB |
v3-0004-plpgsql-yyextra.patch | text/plain | 54.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2024-12-26 18:45:51 | Re: Statistics Import and Export |
Previous Message | David Wheeler | 2024-12-26 18:26:11 | Re: Add Postgres module info |