| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Petr Jelinek <petr(at)2ndquadrant(dot)com> |
| Subject: | Re: logical replication launcher crash on buildfarm |
| Date: | 2017-03-17 03:24:07 |
| Message-ID: | 4d126046-3eee-b87c-b0e4-9506dae249db@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/16/17 14:55, Andres Freund wrote:
> I indeed think that's the right consequence. One question is what to
> replace it with exactly - are we guaranteed we can dynamically lookup
> symbols by name in the main binary on every platform?
I think there is probably a way to do this on all platforms. But it
seems that at least the Windows port of pg_dlopen would need to be
updated to support this.
> Alternatively we
> can just hardcode a bunch of bgw_function_name values that are matched
> to specific functions if bgw_library_name is NULL - I suspect that'd be
> the easiest / least worrysome portability-wise.
Basically a variant of fmgrtab, which addresses the same sort of problem.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2017-03-17 03:33:02 | Re: WAL Consistency checking for hash indexes |
| Previous Message | Noah Misch | 2017-03-17 03:23:27 | Re: possible encoding issues with libxml2 functions |