| From: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PoC/WIP: Extended statistics on expressions |
| Date: | 2021-06-06 19:13:17 |
| Message-ID: | 4c98203c-8364-bb76-b502-d7b323ba55ba@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 6/6/21 7:37 AM, Noah Misch wrote:
> On Sat, Mar 27, 2021 at 01:17:14AM +0100, Tomas Vondra wrote:
>> OK, pushed after a bit more polishing and testing.
>
> This added a "transformed" field to CreateStatsStmt, but it didn't mention
> that field in src/backend/nodes. Should those functions handle the field?
>
Yup, that's a mistake - it should do whatever CREATE INDEX is doing. Not
sure if it can result in error/failure or just inefficiency (due to
transforming the expressions repeatedly), but it should do whatever
CREATE INDEX is doing.
Thanks for noticing! Fixed by d57ecebd12.
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-06-06 19:17:36 | Re: PoC/WIP: Extended statistics on expressions |
| Previous Message | Tom Lane | 2021-06-06 19:10:07 | Re: Since '2001-09-09 01:46:40'::timestamp microseconds are lost when extracting epoch |