Re: automatically generating node support functions

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: automatically generating node support functions
Date: 2022-05-04 15:45:55
Message-ID: 4c0d7a26-974d-7196-5700-0fa726289051@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 19.04.22 13:40, Alvaro Herrera wrote:
> I rebased this mostly out of curiousity. I fixed some smallish
> conflicts and fixed a typedef problem new in JSON support; however, even
> with these fixes it doesn't compile, because JsonPathSpec uses a novel
> typedef pattern that apparently will need bespoke handling in the
> gen_nodes_support.pl script. It seemed better to post this even without
> that, though.

I have committed your change to the JsonTableColumnType enum and the
removal of JsonPathSpec. Other than that and some whitespace changes, I
didn't find anything in your 0002 patch that was different from my last
submitted patch. Did I miss anything?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2022-05-04 16:03:07 Re: automatically generating node support functions
Previous Message David G. Johnston 2022-05-04 15:44:01 Re: JSON Functions and Operators Docs for v15