Re: pgsql: Convert debug message from ereport to elog

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Convert debug message from ereport to elog
Date: 2018-06-15 04:24:15
Message-ID: 4c06e956-c6df-7289-c9fa-55e9370d056e@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

> Just out of curiosity, what is the reason why you did this? I guess

This made a message consistent with an analogous message in
apply_handle_update() earlier in the file.

> using elog instead of ereport for debugging message is preferable,
> while for non debugging messages using ereport is preferable, but
> actually sometimes elog is used for error messages in the file.

I think this is not done perfectly consistently, and there are
possibilities for improvement.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tatsuo Ishii 2018-06-15 04:53:00 Re: pgsql: Convert debug message from ereport to elog
Previous Message Alvaro Herrera 2018-06-14 17:20:07 pgsql: Fail BRIN control functions during recovery explicitly