Logical replication can be broken by domain constraint with NOT VALID option

Hi,

During patch development I ran into a small problem (see attachment,
fail_replication.sh):
1. We have a table with logical replication to another node.
2. On the master and replica add such "NOT VALID" domain constraint on
the table that some tuples violates the constraint.
3. UPDATE the table: set value of the tuple that violates constraint to
correct value.
4. That's all!

The reason for this problem is that on UPDATE walsender sends old tuple
value (that violates the constraint) with new version (satisfied the
constraint).
Replication worker at replica node restores slot from transfer
representation. During this process domain checking constraint and
returns an ERROR.
Because we can't apply WAL record of the UPDATE command, logical
replication will be stopped at all.
As I understand, this problem can be reproduced in all postgres versions
with logical replication feature.
This problem can be solved by many ways and approaches. I wrote the
patch to solve this problem (see in attachment) by the shortest way.

--
Andrey Lepikhov
Postgres Professional
https://postgrespro.com
The Russian Postgres Company