| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Shubham Barai <shubhambaraiss(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Kevin Grittner <kgrittn(at)gmail(dot)com>, Andrew Borodin <amborodin86(at)gmail(dot)com> |
| Subject: | Re: GSoC 2017 : Patch for predicate locking in Gist index |
| Date: | 2017-06-21 07:42:46 |
| Message-ID: | 4bba2c6b-b064-62c9-eca9-611072bea206@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 06/21/2017 10:41 AM, Heikki Linnakangas wrote:
> On 06/16/2017 01:24 PM, Shubham Barai wrote:
>> @@ -497,6 +499,13 @@ gistplacetopage(Relation rel, Size freespace, GISTSTATE *giststate,
>> for (ptr = dist->next; ptr; ptr = ptr->next)
>> UnlockReleaseBuffer(ptr->buffer);
>> }
>> +
>> + for (ptr = dist; ptr; ptr = ptr->next)
>> + PredicateLockPageSplit(rel,
>> + BufferGetBlockNumber(buffer),
>> + BufferGetBlockNumber(ptr->buffer));
>> +
>> +
>
> I think this new code needs to go before the UnlockReleaseBuffer() calls
> above. Calling BufferGetBlockNumber() on an already-released buffer is
> not cool.
.. and that's exactly what you fixed in your updated patch. Sorry for
the noise :-)
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mahendranath Gurram | 2017-06-21 07:43:28 | Re: Regarding Postgres Dynamic Shared Memory (DSA) |
| Previous Message | Heikki Linnakangas | 2017-06-21 07:41:36 | Re: GSoC 2017 : Patch for predicate locking in Gist index |