| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | jian he <jian(dot)universality(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Japin Li <japinli(at)hotmail(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Improve readability by using designated initializers when possible |
| Date: | 2024-03-18 07:09:14 |
| Message-ID: | 4b2ce19f-3e38-4b54-beea-172f9bd031c3@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 14.03.24 01:26, Michael Paquier wrote:
> -EventTriggerSupportsObjectClass(ObjectClass objclass)
> +EventTriggerSupportsObject(const ObjectAddress *object)
>
> The shortcut introduced here is interesting, but it is inconsistent.
> HEAD treats OCLASS_SUBSCRIPTION as something supported by event
> triggers, but as pg_subscription is a shared catalog it would be
> discarded with your change. Subscriptions are marked as supported in
> the event trigger table:
> https://www.postgresql.org/docs/devel/event-trigger-matrix.html
Ah, good catch. Subscriptions are a little special there. Here is a
new patch that keeps the switch/case arrangement in that function. That
also makes it easier to keep the two EventTriggerSupports... functions
aligned. Also added a note about subscriptions and a reference to the
documentation.
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Remove-ObjectClass.patch | text/plain | 53.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2024-03-18 07:18:28 | Re: speed up a logical replica setup |
| Previous Message | Hayato Kuroda (Fujitsu) | 2024-03-18 07:09:10 | RE: PostgreSQL 17 Release Management Team & Feature Freeze |