From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: Generate fmgr prototypes automatically |
Date: | 2017-01-19 14:33:58 |
Message-ID: | 4acaf9d0-012d-7423-880b-e2ce12b900f0@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On 1/17/17 3:07 PM, Tom Lane wrote:
> Alternatively ... is there a specific reason why you chose to make
> builtins.h the key inclusion file for this change, rather than having
> callers include fmgrprotos.h directly? It seems like the stuff remaining
> in builtins.h is just a laundry list of random utility functions.
> Maybe dispersing those to other headers is the thing to do.
Here is a patch that moves two blocks from builtins.h into separate
header files. That avoids having to include nodes/pg_list.h and
utils/sortsupport.h.
The remaining inclusion of nodes/nodes.h is for the oidparse() function.
I think that could be moved out of oid.c and put somewhere near parser/
or objectaddress.c. But the practical savings from avoiding nodes.h is
probably near zero, so I haven't done anything about that here.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachment | Content-Type | Size |
---|---|---|
0001-Move-some-things-from-builtins.h-to-new-header-files.patch | text/x-patch | 26.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2017-01-19 15:26:14 | Re: pgsql: Add function to import operating system collations |
Previous Message | Tom Lane | 2017-01-19 12:53:31 | Re: pgsql: Add function to import operating system collations |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2017-01-19 14:38:14 | Re: Re: Clarifying "server starting" messaging in pg_ctl start without --wait |
Previous Message | Dave Cramer | 2017-01-19 14:22:23 | SEGFAULT in HEAD with replication |