From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Fix integer-overflow problems in interval comparison. |
Date: | 2017-04-17 16:39:31 |
Message-ID: | 4a192a84-9004-2263-6447-0fef95e18fa6@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On 4/5/17 23:51, Tom Lane wrote:
> Fix integer-overflow problems in interval comparison.
> Branch
> ------
> REL9_4_STABLE
>
> Details
> -------
> http://git.postgresql.org/pg/commitdiff/8851bcf8813baa0ea393ef9d2894d15b3f13f957
>
> Modified Files
> --------------
> src/backend/utils/adt/timestamp.c | 65 ++++++++--
> src/include/common/int128.h | 231 +++++++++++++++++++++++++++++++++
> src/test/regress/expected/interval.out | 64 +++++++++
> src/test/regress/sql/interval.sql | 27 ++++
> 4 files changed, 376 insertions(+), 11 deletions(-)
This is failing cpluspluscheck now because C++ does not have
_Static_assert, which is used in int128.h.
I suppose this header is not intended for public consumption, at least
in the back branches, so it would be OK to exclude it from the check.
Perhaps a different solution would be appropriate in master.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2017-04-17 16:51:53 | pgsql: Back-patch 9.4-era SSL renegotiation code into 9.3 and 9.2. |
Previous Message | Peter Eisentraut | 2017-04-17 13:53:54 | pgsql: Document that ONLY can be specified in publication commands |