| From: | Jan Urbański <wulczer(at)wulczer(dot)org> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | hlinnaka(at)iki(dot)fi, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>, Asif Naeem <asif(dot)naeem(at)enterprisedb(dot)com> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Fix mapping of PostgreSQL encodings to Python encodings. |
| Date: | 2012-07-05 21:54:26 |
| Message-ID: | 4FF60D12.2030806@wulczer.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 05/07/12 23:30, Peter Eisentraut wrote:
> On tor, 2012-07-05 at 22:53 +0200, Jan Urbański wrote:
>> The problem is that PLyUnicode_Bytes is (via an ifdef) used as
>> PyString_ToString on Python3, which means that there are numerous call
>> sites and new ones might appear in any moment. I'm not that keen on
>> invoking the traceback machinery on low-level encoding errors.
>
> Why not?
Because it can lead to recursion errors, like the one this patch was
supposed to fix. The traceback machinery calls into the encoding
functions, because it converts Python strings (like function names) into
C strings.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2012-07-06 03:36:46 | pgsql: Fix PGDATAOLD and PGDATANEW to properly set pgconfig location, p |
| Previous Message | Peter Eisentraut | 2012-07-05 21:30:52 | Re: Re: [COMMITTERS] pgsql: Fix mapping of PostgreSQL encodings to Python encodings. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christopher Browne | 2012-07-05 22:03:26 | Re: Schema version management |
| Previous Message | Dimitri Fontaine | 2012-07-05 21:52:12 | Re: Schema version management |