Re: BUG #6510: A simple prompt is displayed using wrong charset

From: Alexander LAW <exclusion(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Pg Bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #6510: A simple prompt is displayed using wrong charset
Date: 2012-03-20 19:50:14
Message-ID: 4F68DF76.1030609@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-general pgsql-hackers

Thanks, I've understood your point.
Please look at the patch. It implements the first way and it makes psql
work too.

Regards,
Alexander

20.03.2012 00:05, Alvaro Herrera пишет:
> Excerpts from Alexander LAW's message of dom mar 18 06:04:51 -0300 2012:
>> I see two ways to resolve the issue.
>> First is to use CharToOemBuff when writing a string to the "con" and
>> OemToCharBuff when reading an input from it.
>> The other is to always use stderr/stdin for Win32 as it was done for
>> msys before. I think it's more straightforward.
> Using console directly instead of stdin/out/err is more appropriate when
> asking for passwords and reading them back, because you can redirect the
> rest of the output to/from files or pipes, without the prompt
> interfering with that. This also explains why stderr is used instead of
> stdout.
>

Attachment Content-Type Size
sprompt.diff text/x-patch 1.1 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message neeraj.punmiya 2012-03-21 09:36:44 BUG #6548: NOWAIT does not work in Select statement if table is locked using "Lock " command
Previous Message Merlin Moncure 2012-03-20 19:07:10 Re: [GENERAL] Altering a table with a rowtype column

Browse pgsql-general by date

  From Date Subject
Next Message Andy Chambers 2012-03-20 20:01:13 pg-admin development snapshots
Previous Message Edoardo Panfili 2012-03-20 19:36:18 Re: Is it even possible?

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2012-03-20 20:00:14 Re: Memory usage during sorting
Previous Message Greg Stark 2012-03-20 19:41:51 Re: Memory usage during sorting