From: | Andrew Dunstan <andrew(dot)dunstan(at)pgexperts(dot)com> |
---|---|
To: | "David E(dot) Wheeler" <david(at)justatheory(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: regress bug |
Date: | 2012-03-08 20:20:59 |
Message-ID: | 4F5914AB.4040102@pgexperts.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 03/08/2012 02:59 PM, David E. Wheeler wrote:
> On Mar 8, 2012, at 10:22 AM, Andrew Dunstan wrote:
>
>> This seems like an outright bug. I don't recall any discussion on it. Maybe nobody's come across it before. ISTM the correct behaviour would be to put converted sql files in $inputdir/sql and converted results files in $outputdir/expected.
> In my extension distributions, I have
>
> tests/sql
> tests/expected
>
> And for that, --inputdir=test works just fine. I don't mess with --outputdir, which just seems to affect where the actual output is written to, which is just a directory named regression.out at the top of the project.
>
It works fine if you don't need to do any file conversions (i.e. if you
don't have "input" or "output" directories). But file_textarray_fdw does.
Here's a patch that I think fixes the problem.
cheers
andrew
Attachment | Content-Type | Size |
---|---|---|
regress.patch | text/x-patch | 1.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | David E. Wheeler | 2012-03-08 20:26:06 | Re: regress bug |
Previous Message | David E. Wheeler | 2012-03-08 19:59:33 | Re: regress bug |