| From: | Jan Urbański <wulczer(at)wulczer(dot)org> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Potential reference miscounts and segfaults in plpython.c |
| Date: | 2012-02-22 12:37:25 |
| Message-ID: | 4F44E185.4090706@wulczer.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 21/02/12 18:28, Jan Urbański wrote:
> On 21/02/12 18:05, Peter Eisentraut wrote:
>>> it might be better to use ereport, to expose the message
>>> for translation.
>>>
> After giving it some thought some of these elogs could be changed into
> PLy_elogs (which is meant to propagate a Python error into Postgres) and
> the others made into ereports.
>
> I'll send updated patches this evening (CET).
Inevitably, this turned into the next morning CET.
Here are the updated patches which use PLy_elog instead of plain elog.
The difference is that they will get marked for translation and that the
original Python exception will show up in the errdetail field.
Cheers,
Jan
| Attachment | Content-Type | Size |
|---|---|---|
| cpychecker-fixes-v2.patch | text/x-diff | 4.7 KB |
| cpychecker-fixes-9.1-v2.patch | text/x-diff | 4.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Padua Krauss | 2012-02-22 12:50:17 | temporal algebra and data type |
| Previous Message | Simon Riggs | 2012-02-22 12:30:46 | Re: 16-bit page checksums for 9.2 |