Re: run GUC check hooks on RESET

From: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
To: "Robert Haas" <robertmhaas(at)gmail(dot)com>
Cc: <pgsql-hackers(at)postgresql(dot)org>,<tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: run GUC check hooks on RESET
Date: 2012-02-15 22:36:01
Message-ID: 4F3BDEF10200002500045668@gw.wicourts.gov
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Feb 15, 2012 at 4:47 PM, Kevin Grittner
> <Kevin(dot)Grittner(at)wicourts(dot)gov> wrote:
>> That is unfortunate. I guess it points out the value of adding a
>> comment to point out why we would want to check these values even
>> on a reset to a previously-used value.
>
> +1 for such a comment.

Will do.

>>> I assume that you're thinking we'd only fix this in master?
>>
>> Without this, I don't think it's possible for someone to enforce
>> protection of their data through SSI in an ironclad way. So
>> there is at least some case to be made to take it back as far as
>> 9.1.
>
> I'm OK with that, but perhaps the only-tangentially-related
> changes where you swap the order of certain error messages ought
> to be separated out and committed only to master? That stuff
> doesn't seem like material for a back-patch.

Agreed. I'm not sure we want to change the message text at all in
9.1. Translations and all that.

-Kevin

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Gaetano Mendola 2012-02-15 22:54:11 Re: CUDA Sorting
Previous Message Tom Lane 2012-02-15 22:29:41 Re: Designing an extension for feature-space similarity search