Re: When do we lose column names?

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: When do we lose column names?
Date: 2012-02-15 04:44:23
Message-ID: 4F3B3827.7040803@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 02/14/2012 05:39 PM, Tom Lane wrote:
> OK, I fixed this up and committed it. I made some cosmetic changes
> (the most notable being that the definition of RowExpr is really
> changing here, and so should its comment). The adjust_appendrel_attrs
> situation was fixed by passing in the PlannerInfo, which is something
> that probably should have been made available all along --- there are
> very few nontrivial functions in the planner that don't need it.

Great, many thanks for finishing this up.

>
> I'm still a bit annoyed by the behavior I mentioned here,
> http://archives.postgresql.org/pgsql-hackers/2011-11/msg01031.php
> that we don't get "real" column names from an unflattened VALUES RTE.
> Might be worth looking into that, but I don't have time for it.
>
>

A TODO maybe?

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2012-02-15 05:23:04 Re: client performance v.s. server statistics
Previous Message Zhou Han 2012-02-15 03:59:36 client performance v.s. server statistics