| From: | Greg Smith <greg(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch to allow users to kill their own queries |
| Date: | 2012-01-13 13:42:52 |
| Message-ID: | 4F1034DC.1050006@2ndQuadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 01/03/2012 12:59 PM, Tom Lane wrote:
> Noah Misch<noah(at)leadboat(dot)com> writes:
>
>> Regarding the other message, avoid composing a translated message from
>> independently-translated parts.
>>
> Yes. I haven't looked at the patch, but I wonder whether it wouldn't be
> better to dodge both of these problems by having the subroutine return a
> success/failure result code, so that the actual ereport can be done at
> an outer level where the full message (and hint) can be written
> directly.
>
Between your and Noah's comments I understand the issue and likely
direction to sort this out now. Bounced forward to the next CommitFest
and back on my plate again. Guess I'll be learning new and exciting
things about translation this week.
--
Greg Smith 2ndQuadrant US greg(at)2ndQuadrant(dot)com Baltimore, MD
PostgreSQL Training, Services, and 24x7 Support www.2ndQuadrant.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2012-01-13 13:46:15 | Re: Patch to allow users to kill their own queries |
| Previous Message | Robert Haas | 2012-01-13 13:33:27 | Re: Poorly thought out code in vacuum |