Re: [COMMITTERS] pgsql: Fix breakage from earlier plperl fix.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Alex Hunsaker <badalex(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Fix breakage from earlier plperl fix.
Date: 2012-01-06 19:13:41
Message-ID: 4F0747E5.2090502@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 01/06/2012 02:02 PM, Alex Hunsaker wrote:
>> 3. The above is in any case almost certainly insufficient, because in my
>> tests a typeglob didn't trigger SvREADONLY(), but did cause a crash.
> Hrm the glob I was testing was *STDIN. It failed to fail in my test
> program because I was not testing *STDIN directly but instead had
> @test = (*STDIN); Ugh. Playing with it a bit more it seems only
> *STDIN, *STDERR and *STDOUT have problems. For example this seems to
> work fine for me:
> do LANGUAGE plperlu $$ open(my $fh, '>', '/tmp/t.tmp'); elog(NOTICE, $fh) $$;
>
>

$fh isn't a typeglob here, AIUI. But it's definitely not just *STDIN and
friends. Try:

do LANGUAGE plperlu $$ $foo=1; elog(NOTICE, *foo) $$;

cheers

andrew

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2012-01-06 19:33:15 pgsql: Make the number of CLOG buffers adaptive, based on shared_buffer
Previous Message Alex Hunsaker 2012-01-06 19:02:49 Re: [COMMITTERS] pgsql: Fix breakage from earlier plperl fix.

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2012-01-06 19:28:28 Re: WIP(!) Double Writes
Previous Message Alex Hunsaker 2012-01-06 19:02:49 Re: [COMMITTERS] pgsql: Fix breakage from earlier plperl fix.