| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Brar Piening <brar(at)gmx(dot)de> |
| Cc: | Craig Ringer <craig(at)postnewspapers(dot)com(dot)au>, PG Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Review of VS 2010 support patches |
| Date: | 2012-01-01 23:01:45 |
| Message-ID: | 4F00E5D9.90606@dunslane.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/31/2011 06:10 PM, Brar Piening wrote:
> Brar Piening wrote:
>> Andrew Dunstan wrote:
>>> Can you narrow down exactly what in that commit broke VS 2010? Are
>>> there any compiler warnings?
>>
>> I was able to nail down the problem.
>
> In the absence of reaction, to keep my promise, I'm sending the
> attached Patch which restores the previous working behaviour for
> Visual Studio 2011.
> Note however that it also restores the previous conflicts with errno.h
> which aren't neccessarily a problem, but might be in future.
>
Yeah, are we bothered by this?:
+ * For Microsoft Visual Studio 2010 and above we intentionally redefine
+ * the regular Berkeley error constants and set them to the WSA constants.
+ * Note that this will break if those constants are used for anything else
+ * than Windows Sockets errors.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2012-01-02 04:32:33 | controlling the location of server-side SSL files |
| Previous Message | Daniel Farina | 2012-01-01 22:09:52 | Re: backup_label during crash recovery: do we know how to solve it? |