| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Issue with cancel_before_shmem_exit while searching to remove a particular registered exit callbacks |
| Date: | 2023-11-16 21:05:19 |
| Message-ID: | 4EF5DD92-15E2-413F-AD6D-C2D29C98D29D@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 30 Jul 2020, at 14:11, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> On Mon, Jul 20, 2020 at 3:47 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> But I also agree that what pg_start_backup() was doing before v13 was
>> wrong; that's why I committed
>> 303640199d0436c5e7acdf50b837a027b5726594. The only reason I didn't
>> back-patch it is because the consequences are so minor I didn't think
>> it was worth worrying about. We could, though. I'd be somewhat
>> inclined to both do that and also change LLVM to use on_proc_exit() in
>> master, but I don't feel super-strongly about it.
>
> Unless somebody complains pretty soon, I'm going to go ahead and do
> what is described above.
When backpatching 9dce22033d5d I ran into this in v13 and below, since it needs
llvm_shutdown to happen via on_proc_exit in order for all llvm_release_context
calls to have finished. Unless anyone objects I will backpatch bab150045bd97
to v12 and v13 as part of my backpatch.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrei Zubkov | 2023-11-16 21:35:46 | Re: [PATCH] Tracking statements entry timestamp in pg_stat_statements |
| Previous Message | Robert Haas | 2023-11-16 20:52:10 | Re: lazy_scan_heap() should release lock on buffer before vacuuming FSM |