Re: Postgresql 9.1.2 - abnormal memory usage

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-bugs(at)postgresql(dot)org, Jochen Erwied <jochen(at)pgsql-bugs(dot)erwied(dot)eu>
Subject: Re: Postgresql 9.1.2 - abnormal memory usage
Date: 2011-12-12 08:29:36
Message-ID: 4EE5BB70.4090903@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On 12.12.2011 08:26, Tom Lane wrote:
> Andres Freund<andres(at)anarazel(dot)de> writes:
>> In 3b8161723c645853021b57330dd2ea0484ec6131 Heikki made DatumGetInetP unpack
>> toasted values. Unfortunately the btree support functions for the inet type
>> didn't free memory which they have to do in contrast to about everything else.
>
>> I fixed a few more functions than strictly necessary but I guess thats ok.
>
> Seems like the correct fix is to revert these functions to the former
> behavior, ie they should be using the PP macros not the unpacking ones.

Agreed, there's no need to unpack here. Fixed, thanks for the report!

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message vbberdin 2011-12-12 09:09:10 BUG #6331: Cross compile error/aborts. Works if '--disable-spinlock' is used
Previous Message Jochen Erwied 2011-12-12 07:04:44 Re: Postgresql 9.1.2 - abnormal memory usage