pg_dump - foreign table - server name is not quoted

From: Ronan Dunklau <rdunklau(at)gmail(dot)com>
To: pgsql-bugs(at)postgresql(dot)org
Subject: pg_dump - foreign table - server name is not quoted
Date: 2011-11-28 13:30:11
Message-ID: 4ED38CE3.5060503@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Hello.

I noticed what I think is a bug in pg_dump.

When dumping foreign tables, the server name is not properly quoted,
which leads to unrestorable dumps.

eg, a foreign table attached to a foreign server named "file-test" is
dumped as:

CREATE FOREIGN TABLE "test-table" (
col1 integer
)
SERVER file-test
OPTIONS (filename '/tmp/test');

Please look at the attached test case and the proposed patch.

Thank you.

--
Ronan Dunklau

Attachment Content-Type Size
bug_dump_fdw.sql text/x-sql 266 bytes
bug_dump_foreign_server.patch text/x-patch 639 bytes

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2011-11-28 16:51:58 Re: pg_dump - foreign table - server name is not quoted
Previous Message Thomas Goerner 2011-11-28 12:26:26 Re: BUG #6308: Problem w. encoding in client