| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Modify pg_dump to use error-free memory allocation macros. This |
| Date: | 2011-11-26 13:20:24 |
| Message-ID: | 4ED0E798.5030504@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 11/26/2011 02:13 AM, Tom Lane wrote:
> Bruce Momjian<bruce(at)momjian(dot)us> writes:
>> Modify pg_dump to use error-free memory allocation macros. This avoids
>> ignoring errors and call-site error checking.
> This appears to have broken the MSVC build. More generally, I'd like to
> object to arbitrarily moving a bunch of longstanding code from one file
> to another. What that is mainly going to accomplish is creating a big
> headache whenever we have to back-patch fixes that touch that code
> ... and what exactly did it buy in return?
>
>
Was there any discussion of this change? It seems much too big for
something to be done without discussion, but I don't recall seeing
anything. (And it's probably seriously broken two patches I have in the
commitfest).
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2011-11-26 14:11:09 | Re: pgsql: Modify pg_dump to use error-free memory allocation macros. This |
| Previous Message | Heikki Linnakangas | 2011-11-26 10:16:41 | pgsql: Take fillfactor into account in the new COPY bulk heap insert co |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2011-11-26 14:11:09 | Re: pgsql: Modify pg_dump to use error-free memory allocation macros. This |
| Previous Message | Peter Eisentraut | 2011-11-26 12:38:43 | Re: vpath builds and verbose error messages |