| From: | "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> |
|---|---|
| To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "Andrew Dunstan" <andrew(at)dunslane(dot)net>, "Robert Haas" <robertmhaas(at)gmail(dot)com>, "Peter Eisentraut" <peter_e(at)gmx(dot)net>,<pgsql(at)j-davis(dot)com>, <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: new compiler warnings |
| Date: | 2011-10-18 20:34:18 |
| Message-ID: | 4E9D9C7A02000025000421D9@gw.wicourts.gov |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I don't think the assert is a good idea. If it ever did happen,
> that would promote the problem from "corrupted data in the log" to
> "database crash".
... on a --enable-cassert build.
If we think it's even remotely possible that it could happen, maybe
we should do the loop. That would change the current "missing log
information" situation to "interleaved log information".
But if we think it would be better for data to be missing from the
log than interleaved, the Assert could be removed and it still
suppresses the error (at least on my machine).
-Kevin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2011-10-18 20:34:22 | Re: new compiler warnings |
| Previous Message | Tom Lane | 2011-10-18 20:28:16 | Re: new compiler warnings |