| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | David Fetter <david(at)fetter(dot)org> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Kris Jurka <books(at)ejurka(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: New copyright program |
| Date: | 2011-08-20 01:22:03 |
| Message-ID: | 4E4F0C3B.4030408@dunslane.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 08/19/2011 09:02 PM, David Fetter wrote:
> On Fri, Aug 19, 2011 at 07:37:29PM -0400, Andrew Dunstan wrote:
>>
>> On 08/19/2011 07:31 PM, Bruce Momjian wrote:
>>> Kris Jurka wrote:
>>>> Did you also try the "use Tie::File" addition in my fix because your
>>>> current coding doesn't work at all. The tie operation is key to actually
>>>> writing out the modified copyright notice. Your version just updates the
>>>> copyright year in memory, but never gets it back to the file.
>>> Ah, that did fix it; thanks. I am attached the updated committed
>>> copyright.pl. I also skipped symlinks.
>>>
>> It probably doesn't matter that much in this context, but I should
>> point out that Tie::File is not universally available. Some years
>> ago I had to revert its use in the buildfarm code for that reason.
>> In general we should try to avoid adding extra dependencies wherever
>> possible.
> Tie::File ships as part of core Perl for all non-EOL versions, so I
> really can't consider this as a problem.
Which are those?
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Fetter | 2011-08-20 01:39:27 | Re: New copyright program |
| Previous Message | David Fetter | 2011-08-20 01:02:14 | Re: New copyright program |