| From: | Mark Kirkwood <mark(dot)kirkwood(at)catalyst(dot)net(dot)nz> |
|---|---|
| To: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
| Cc: | josh(at)agliodbs(dot)com, cedric(dot)villemain(dot)debian(at)gmail(dot)com, robertmhaas(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Re: patch review : Add ability to constrain backend temporary file space |
| Date: | 2011-07-14 10:34:30 |
| Message-ID: | 4E1EC636.40700@catalyst.net.nz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 14/07/11 18:48, Tatsuo Ishii wrote:
>
> Hi I am the new reviewer:-)
>
> I have looked into the v6 patches. One thing I would like to suggest
> is, enhancing the error message when temp_file_limit will be exceeded.
>
> ERROR: aborting due to exceeding temp file limit
>
> Is it possible to add the current temp file limit to the message? For
> example,
>
> ERROR: aborting due to exceeding temp file limit 10000kB
>
> I know the current setting of temp_file_limit can be viewd in other
> ways, but I think this will make admin's or application developer's
> life a little bit easier.
Hi Tatsuo,
Yeah, good suggestion - I agree that it would be useful to supply extra
detail, I'll amend and resubmit a new patch (along with whatever review
modifications we come up with in the meantime)!
Cheers
Mark
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2011-07-14 12:09:22 | Understanding GIN posting trees |
| Previous Message | Alexander Korotkov | 2011-07-14 10:29:36 | Re: Small patch for GiST: move childoffnum to child |