| From: | Josh Berkus <josh(at)agliodbs(dot)com> |
|---|---|
| To: | PG Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Florian Pflug <fgp(at)phlo(dot)org>, Radosław Smogura <rsmogura(at)softperience(dot)eu>, Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Subject: | Re: Patch Review: Bugfix for XPATH() if text or attribute nodes are selected |
| Date: | 2011-07-10 18:40:54 |
| Message-ID: | 4E19F236.4080507@agliodbs.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hackers,
>> B. 6. Current behaviour _is intended_ (there is "if" to check node type) and _"natural"_. In this particular case user ask for text content of some node, and this content is actually "<".
>
> I don't buy that. The check for the node type is there because
> two different libxml functions are used to convert nodes to
> strings. The if has absolutely *zero* to do with escaping, expect
> for that missing escape_xml() call in the "else" case.
>
> Secondly, there is little point in having an type XML if we
> don't actually ensure that values of that type can only contain
> well-formed XML.
Can anyone else weigh in on this? Peter?
--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Berkus | 2011-07-10 18:43:14 | Re: Small patch for GiST: move childoffnum to child |
| Previous Message | Josh Berkus | 2011-07-10 18:34:39 | Re: patch for distinguishing PG instances in event log |