| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | David Blewett <david(at)dawninglight(dot)net> |
| Cc: | Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Greg Stark <gsstark(at)mit(dot)edu>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: branching for 9.2devel |
| Date: | 2011-05-04 04:10:57 |
| Message-ID: | 4DC0D1D1.9020800@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 05/03/2011 09:53 PM, David Blewett wrote:
> On Tue, May 3, 2011 at 9:51 PM, David Blewett<david(at)dawninglight(dot)net> wrote:
>> This seems like a pretty good idea, but maybe it'd be easiest to take
>> it a step further and add an "automatic pgindent-ified" patch is
>> created when a patch is added to the commitfest app?
> That should read: ... but maybe it'd be easiest to take it a step
> further and have an additional, automatically created patch file that
> is run through pgindent when a patch is added to the commitfest app.
>
You can't indent patches, only patched files. And that's the problem
with this happy scheme. For it to work at all sanely we'd need to keep
the committed code that the patch is to be applied against strictly
pgindent clean, presumably via some automated process such as a commit
hook. That's been suggested in the past, but hasn't met with universal
approval, IIRC.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-05-04 04:19:51 | Re: branching for 9.2devel |
| Previous Message | Greg Smith | 2011-05-04 02:57:07 | Re: Predicate locking |