| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | code cleanups |
| Date: | 2011-04-23 23:03:23 |
| Message-ID: | 4DB35ABB.9010904@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
getopt.c is looking a bit ancient. In particular, getopt() has no
prototype and old style arguments. Is there any reason not to bring this
into the 1990s (or is that 1980s?)
gcc also doesn't like the way perl does unused attributes on Windows,
and it generates quite a few warnings about it. A little experimentation
suggests this would probably clean it up if placed at the start of plperl.h:
#if defined(__GNUC_)
#define PERL_UNUSED_DECL __attribute__ ((unused))
#endif
Thoughts?
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniele Varrazzo | 2011-04-24 00:10:14 | Re: Extension Packaging |
| Previous Message | Bruce Momjian | 2011-04-23 21:21:29 | Re: Patch for pg_upgrade to turn off autovacuum |