Re: Re: [COMMITTERS] pgsql: setlocale() on Windows doesn't work correctly if the locale name

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: setlocale() on Windows doesn't work correctly if the locale name
Date: 2011-04-20 06:30:24
Message-ID: 4DAE7D80.5000001@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 20.04.2011 06:48, Hiroshi Inoue wrote:
> I can find no concrete reference to problems about locale
> names containing dots. Is the following an example?

Yes.

> In my environment (Windows Vista using VC8)
>
> setlocale(LC_XXXX, "Chinese (Traditional)_MCO.950");
> works and
> setlocale(LC_XXXX, NULL);
> returns
> Chinese (Traditional)_Macao S.A.R..950

Interesting. According to Microsoft's documentation, the codes are
three-letter country codes specified by ISO-3166
(http://msdn.microsoft.com/en-us/library/cdax410z%28v=VS.100%29.aspx)
However, according to Wikipedia, MCO stands for Monaco, not Macau
(https://secure.wikimedia.org/wikipedia/en/wiki/ISO_3166-1_alpha-3)

So according to bug #5818, the problem with "People's Republic of China"
was different from "Hong Kong S.A.R.", "Macau S.A.R.", and "U.A.E.".
setlocale() handles apostrophe fine, but it's not escaped correctly in
the BKI file. I'll remove the "People's Republic of China" -> "China"
mapping I committed, and fix the escaping instead.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2011-04-20 07:07:53 pgsql: Quotes in strings injected into bki file need to escaped. In par
Previous Message Hiroshi Inoue 2011-04-20 03:48:14 Re: [HACKERS] Re: pgsql: setlocale() on Windows doesn't work correctly if the locale name

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2011-04-20 09:48:34 Re: pgindent weirdness
Previous Message Pavel Stehule 2011-04-20 06:05:07 Re: pgbench \for or similar loop