| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Rename pg_regress option --multibyte to --encoding |
| Date: | 2011-04-16 19:07:39 |
| Message-ID: | 4DA9E8FB.1020100@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 04/15/2011 04:36 PM, Peter Eisentraut wrote:
> On Fri, 2011-04-15 at 12:28 -0400, Andrew Dunstan wrote:
>> Yeah, what is the point of this?:
>>
>> -# Adjust REGRESS_OPTS because we need a UTF8 database
>> -REGRESS_OPTS = --dbname=$(CONTRIB_TESTDB) --multibyte=UTF8 --no-locale
>> +# We need a UTF8 database +ENCODING = UTF8 +NO_LOCALE = 1
>>
>>
>> Wouldn't it have worked just to change the way we spelled the option
>> name in the REGRESS_OPTS line?
> It would have, but this way you have the same uniform interface
> everywhere. For example, you can easily override the encoding that that
> test prescribes.
>
Well whatever we do, the buildfarm is currently broken for all MSVC
builds because of this change, so I hope you're intending to fix this.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-04-16 20:40:54 | pgsql: Clean up collation processing in prepunion.c. |
| Previous Message | Peter Eisentraut | 2011-04-16 18:54:00 | pgsql: Set client encoding explicitly in plpython_unicode test |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Smith | 2011-04-16 19:19:53 | Re: Formatting Curmudgeons WAS: MMAP Buffers |
| Previous Message | Joshua Berkus | 2011-04-16 18:33:10 | Re: MMAP Buffers |