| From: | Greg Smith <greg(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Joshua Berkus <josh(at)agliodbs(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Rados?aw Smogura <rsmogura(at)softperience(dot)eu>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, PG Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: MMAP Buffers |
| Date: | 2011-04-16 07:06:46 |
| Message-ID: | 4DA94006.6050905@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> * On the other side of the coin, I have seen many a patch that was
> written to minimize the length of the diff to the detriment of
> readability or maintainability of the resulting code, and that's *not*
> a good tradeoff.
>
Sure. that's possible. But based on the reviews I've done, I'd say that
the fact someone is even aware that minimizing their diff is something
important to consider automatically puts them far ahead of the average
new submitter. There are a high percentage of patches where the
submitter generates a diff and sents it without even looking at it.
That a person would look at their diff and go too far without trying to
make it small doesn't happen nearly as much.
--
Greg Smith 2ndQuadrant US greg(at)2ndQuadrant(dot)com Baltimore, MD
PostgreSQL Training, Services, and 24x7 Support www.2ndQuadrant.us
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Smith | 2011-04-16 07:12:23 | Re: MMAP Buffers |
| Previous Message | Tom Lane | 2011-04-16 06:36:08 | Re: MMAP Buffers |