| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Re: [COMMITTERS] pgsql: Add missing keywords to gram.y's unreserved_keywords list. |
| Date: | 2011-03-11 19:39:06 |
| Message-ID: | 4D7A7A5A.2090305@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 11.03.2011 20:59, Robert Haas wrote:
> On Tue, Mar 8, 2011 at 4:44 PM, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Add missing keywords to gram.y's unreserved_keywords list.
>>
>> We really need an automated check for this ... and did VALIDATE really
>> need to become a keyword at all, rather than picking some other syntax
>> using existing keywords?
>
> I think we ought to try to do something about this, so that VALIDATE
> doesn't need to become a keyword.
>
> How about instead of VALIDATE CONSTRAINT we simply write ALTER
> CONSTRAINT ... VALID? (Patch attached, passes make check.)
ALTER CONSTRAINT ... VALID sounds like it just marks the constraint as
valid. "VALIDATE CONSTRAINT" sounds like it scans and checks that the
constraint is valid.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2011-03-11 19:40:34 | Re: Re: [COMMITTERS] pgsql: Add missing keywords to gram.y's unreserved_keywords list. |
| Previous Message | Bruce Momjian | 2011-03-11 19:33:30 | pgsql: In docs, rename "backwards compatibility" to "backward compatibi |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2011-03-11 19:40:34 | Re: Re: [COMMITTERS] pgsql: Add missing keywords to gram.y's unreserved_keywords list. |
| Previous Message | Robert Haas | 2011-03-11 19:34:25 | Re: Replication server timeout patch |