Re: BUG #5915: OldSerXidAdd inflates pg_serial too much

From: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
To: "YAMAMOTO Takashi" <yamt(at)mwd(dot)biglobe(dot)ne(dot)jp>, <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #5915: OldSerXidAdd inflates pg_serial too much
Date: 2011-03-04 19:26:47
Message-ID: 4D70E897020000250003B4B8@gw.wicourts.gov
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

"YAMAMOTO Takashi" <yamt(at)mwd(dot)biglobe(dot)ne(dot)jp> wrote:

> a seemingly wrong math in OldSerXidAdd makes it busy writing zeros
> to pg_serial.
>
> [patch]

Your fix looks correct to me -- we want to get from a SLRU segment
number to the first page of that segment, so SLRU_PAGES_PER_SEGMENT
is the right multiplier.

Thanks!

While I was looking at it, I noticed some obsolete comment lines
which should be removed. Trivial patch attached.

-Kevin

Attachment Content-Type Size
ssi-obsolete-comment.patch text/plain 655 bytes

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Peter Eisentraut 2011-03-04 20:16:26 Re: Cannot create collation?
Previous Message Tom Lane 2011-03-04 16:41:33 Re: Possible regression: libpq + SSL aborts when user has no home directory