Re: Re: [COMMITTERS] pgsql: Fix blatantly uninitialized variable in recent commit.

From: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
To: "Andrew Dunstan" <andrew(at)dunslane(dot)net>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Simon Riggs" <simon(at)2ndQuadrant(dot)com>, <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Fix blatantly uninitialized variable in recent commit.
Date: 2011-02-17 17:54:45
Message-ID: 4D5D0C85020000250003ABAC@gw.wicourts.gov
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:

> Ugh. Isn't there some sort of pragma or similar we can use to shut
> it up?

If that fails, maybe use some function like the below? That would
also have the advantage of not relying on assumptions beyond the
documented API, which I tend to feel good about no matter how sure I
am that the implementation details upon which I'm relying won't
change.

No claims that this is good final form, especially when it comes to
using ssize_t, but just trying to get across the general idea:

void
write_completely_ignore_errors(int filedes, const void *buffer,
size_t size)
{
size_t t = 0;
while (t < size)
{
ssize_t n = write(filedes, buffer, size - t);
if (n <= 0)
break;
t += n;
}
}

-Kevin

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2011-02-17 18:37:05 pgsql: Document that plpgsql upsert example can fail if insert triggers
Previous Message Bruce Momjian 2011-02-17 17:37:43 pgsql: In documentation example, use concat_values() instead of concat(

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2011-02-17 18:04:32 Re: Rewrite, normal execution vs. EXPLAIN ANALYZE
Previous Message Bruce Momjian 2011-02-17 17:51:30 Re: ECPG dynamic cursor fix for UPDATE/DELETE ... WHERE CURRENT OF :curname