| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Joachim Wieland <joe(at)mcknight(dot)de>, Jaime Casanova <jaime(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_dump directory archive format / parallel pg_dump |
| Date: | 2011-01-21 15:34:42 |
| Message-ID: | 4D39A792.80306@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 21.01.2011 15:35, Robert Haas wrote:
> On Fri, Jan 21, 2011 at 4:41 AM, Heikki Linnakangas
> <heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
>> There's one UI thing that bothers me. The option to specify the target
>> directory is called --file. But it's clearly not a file. OTOH, I'd hate to
>> introduce a parallel --dir option just for this. Any thoughts on this?
>
> If we were starting over, I'd probably suggest calling the option -o,
> --output. But since -o is already taken (for --oids) I'd be inclined
> to just make the help text read:
>
> -f, --file=FILENAME output file (or directory) name
> -F, --format=c|t|p|d output file format (custom, tar, text, dir)
Ok, that's exactly what the patch does now. I guess it's fine then.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-01-21 15:35:46 | Re: How to know killed by pg_terminate_backend |
| Previous Message | Magnus Hagander | 2011-01-21 15:34:05 | Re: More detailed auth info |